Maniphest T219318

Lexeme form grammatical feature editing: backspace on pill reveals '[object Object]'
Closed, ResolvedPublic
Actions

Description

Environment: production (example)

GIVEN I am on a lexeme page
AND I have edit permission
WHEN I click edit on a form of the lexeme
AND it has grammatical features (pills) already
AND I type backspace to start editing a preexisting grammatical feature
THEN I see "[object Object]" instead of the Q-id / the label of the item (for product to specify)

Bildschirmfoto von 2019-03-26 20-24-38.png (1×1 px, 109 KB)

Likely caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/491943/1/resources/lib/ooui/oojs-ui-widgets.js#b4390 for T216075

Discovered while tinkering with T219134

Details

	Subject	Repo	Branch	Lines +/-
	Populate with entity's label on backspace.	mediawiki/extensions/WikibaseLexeme	master	+7 -0

Customize query in gerrit

Related Objects

Mentioned In: T239208: Lexemes: Grammatical form can render as `[object Object]`
rEWLE1e98a748e823: Populate with entity's label on backspace.
T220093: Find a solution to render entity's label text in pill without passing jQuery object to EditableTemplatedWidget `selected` property
rEWLEa26121042dc1: Populate with entity's label on backspace.
Mentioned Here: T220093: Find a solution to render entity's label text in pill without passing jQuery object to EditableTemplatedWidget `selected` property
T216075: Pressing backspace to delete a tag in namespace multiselect widget populates the input with the tag data instead of the tag label
T219134: `text.trim is not a function` in node selenium tests blocking Wikibase CI; blocking test/merge in WB/WBL/WBMI/etc.

Event Timeline

• Pablo-WMDE created this task.Mar 26 2019, 7:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2019, 7:41 PM

• Pablo-WMDE updated the task description. (Show Details)Mar 26 2019, 7:55 PM

sarhan.alaa subscribed.Mar 26 2019, 9:29 PM

Lydia_Pintscher added a project: Wikidata-Campsite.Mar 30 2019, 4:58 PM

Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Apr 2 2019, 10:49 AM

• Greta_Doci_WMDE subscribed.Apr 3 2019, 12:41 PM

• Greta_Doci_WMDE claimed this task.Apr 3 2019, 3:45 PM

• Greta_Doci_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Apr 3 2019, 4:02 PM

• Greta_Doci_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 501191 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi):
[mediawiki/extensions/WikibaseLexeme@master] Populate with entity's label on backspace.

https://gerrit.wikimedia.org/r/501191

gerritbot added a project: Patch-For-Review.Apr 4 2019, 11:42 AM

Diffusion mentioned this in rEWLEa26121042dc1: Populate with entity's label on backspace..Apr 4 2019, 11:50 AM

• alaa_wmde mentioned this in T220093: Find a solution to render entity's label text in pill without passing jQuery object to EditableTemplatedWidget `selected` property.Apr 4 2019, 12:00 PM

Diffusion mentioned this in rEWLE1e98a748e823: Populate with entity's label on backspace..Apr 4 2019, 1:45 PM

• Greta_Doci_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 4 2019, 2:19 PM

Change 501191 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Populate with entity's label on backspace.

https://gerrit.wikimedia.org/r/501191

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 8 2019, 1:00 PM

The Gerrit change was merged, and the necessary follow-up mentioned in its comments seems to be covered by the separate task T220093, so I think this can leave the review column.

\o/

Michael mentioned this in T239208: Lexemes: Grammatical form can render as `[object Object]`.Jul 5 2022, 3:37 PM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jul 5 2022, 4:29 PM

Maintenance_bot removed a project: Patch-For-Review.

	F28474118: Bildschirmfoto von 2019-03-26 20-24-38.png
	Mar 26 2019, 7:41 PM

Lexeme form grammatical feature editing: backspace on pill reveals '[object Object]'Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Lexeme form grammatical feature editing: backspace on pill reveals '[object Object]'
Closed, ResolvedPublic
Actions