Page MenuHomePhabricator
Create Task
Maniphest T223916

Adding qualifiers results in the wrong button being focused
Closed, ResolvedPublicBUG REPORT
Actions

Description

User story: N/A

We have this:
Tested on Beta. When I add a qualifier to an item, the "Add qualifier" button is focused. Besides being confusing, this seems like an accessibility issue as well as.

We want this:
For the "Add qualifier" button to not be focused. Instead, automatically focus on the Property dropdown menu so users know what to do next: select a property.

GIF (tap to play):

focus button.gif (316×822 px, 271 KB)

Url to test on beta: https://commons.wikimedia.beta.wmflabs.org/wiki/File:Title_0.9209196250626945.png

Acceptance Criteria:

  • When adding a qualifier, the focus should be on "Property" dropdown, not "Add qualifier" button

QA Results

ACStatusDetails
1✅T223916#5293510

Details

SubjectRepoBranchLines +/-
Focus property when adding new propertymediawiki/extensions/WikibaseMediaInfowmf/1.34.0-wmf.8+1 -1
Focus property when adding new propertymediawiki/extensions/WikibaseMediaInfomaster+1 -1
Focus dropdown when clicking button to add new qualifiermediawiki/extensions/WikibaseMediaInfomaster+10 -0
Customize query in gerrit

Related Objects

Event Timeline

• PDrouin-WMF created this task.May 20 2019, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2019, 3:25 PM
• PDrouin-WMF updated the task description. (Show Details)May 20 2019, 3:29 PM
• Ramsey-WMF assigned this task to matthiasmullie.May 20 2019, 4:12 PM
• Ramsey-WMF triaged this task as Medium priority.
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
• Ramsey-WMF added projects: Structured Data Engineering, Structured-Data-Team-Current-Work, SDC-Statements (Depicts-on-training-wheels).
matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.May 21 2019, 11:17 AM
gerritbot added a comment.May 21 2019, 11:17 AM

Change 511684 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Focus dropdown when clicking button to add new qualifier

https://gerrit.wikimedia.org/r/511684

gerritbot added a project: Patch-For-Review.May 21 2019, 11:17 AM
gerritbot added a comment.May 27 2019, 5:15 PM

Change 511684 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Focus dropdown when clicking button to add new qualifier

https://gerrit.wikimedia.org/r/511684

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).May 27 2019, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 27 2019, 6:10 PM
Cparle moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.May 28 2019, 1:54 PM
Cparle updated the task description. (Show Details)
• PDrouin-WMF added a comment.May 28 2019, 2:00 PM

Works for me!

• Ramsey-WMF added a comment.Jun 10 2019, 5:16 PM

@matthiasmullie This bug was fixed, but has returned in the latest patch that's up on Beta. Could you take a look? Thanks! 😺

• PDrouin-WMF mentioned this in T224624: Quantity qualifier value box is not visible on smartphones.Jun 10 2019, 7:32 PM
gerritbot added a comment.Jun 11 2019, 8:38 AM

Change 516461 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Focus property when adding new property

https://gerrit.wikimedia.org/r/516461

gerritbot added a project: Patch-For-Review.Jun 11 2019, 8:38 AM
matthiasmullie added a comment.Jun 11 2019, 8:40 AM

Oops! I messed up the order of add/focus operations, causing focus to stop working. Patch up, will be fixed shortly!

gerritbot added a comment.Jun 11 2019, 10:13 AM

Change 516461 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Focus property when adding new property

https://gerrit.wikimedia.org/r/516461

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2019, 11:10 AM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.10; 2019-06-18); removed MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).Jun 11 2019, 12:00 PM
Cparle reassigned this task from matthiasmullie to Edtadros.Jun 12 2019, 4:53 PM
Cparle added a subscriber: matthiasmullie.
gerritbot added a comment.Jun 20 2019, 10:14 AM

Change 518000 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.8] Focus property when adding new property

https://gerrit.wikimedia.org/r/518000

gerritbot added a project: Patch-For-Review.Jun 20 2019, 10:14 AM

Change 518000 merged by Matthias Mullie:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.8] Focus property when adding new property

https://gerrit.wikimedia.org/r/518000

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.8; 2019-06-04); removed MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 20 2019, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 20 2019, 11:11 AM
Edtadros reassigned this task from Edtadros to • Ramsey-WMF.Jun 29 2019, 12:34 AM
Edtadros subscribed.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP

Test Artifact(s):

Acceptance Criteria:

✅ AC1: When adding a qualifier, the focus should be on "Property" dropdown, not "Add qualifier" button

T223916.gif (1×1 px, 729 KB)

Edtadros updated the task description. (Show Details)Jun 29 2019, 12:34 AM
• Ramsey-WMF closed this task as Resolved.Jul 30 2019, 4:14 PM

We might revisit this later after more time for community feedback, but this is good to go now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits