Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use more consistent and accurate glob for ignoring subfolders #783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Weetbix
Copy link

@Weetbix Weetbix commented May 22, 2024

Description:
This PR updates the readme to cover this use case a bit more accurately.

Currently, in the example touching files in /src/docs/some/subfolder/file.txt would still add the source label. This is probably not the behaviour most people are interested in, and is a bit different from what the comment says:

Add 'source' label to any change to src files within the source dir EXCEPT for the docs sub-folder

By switching to **/* we can recursively match files inside the docs folder, not just files directly in docs.

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@Weetbix Weetbix requested a review from a team as a code owner May 22, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant